usb/mtp: avoid dynamic stack allocation
authorGerd Hoffmann <kraxel@redhat.com>
Mon, 3 May 2021 13:29:13 +0000 (15:29 +0200)
committerGerd Hoffmann <kraxel@redhat.com>
Tue, 4 May 2021 06:38:40 +0000 (08:38 +0200)
Use autofree heap allocation instead.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20210503132915.2335822-4-kraxel@redhat.com>

hw/usb/dev-mtp.c

index bbb827434482d3b191df857d6fa0f5853cc5e1b6..2a895a73b083315d617e73a12cbd4c9131d02e7a 100644 (file)
@@ -907,7 +907,8 @@ static MTPData *usb_mtp_get_object_handles(MTPState *s, MTPControl *c,
                                            MTPObject *o)
 {
     MTPData *d = usb_mtp_data_alloc(c);
-    uint32_t i = 0, handles[o->nchildren];
+    uint32_t i = 0;
+    g_autofree uint32_t *handles = g_new(uint32_t, o->nchildren);
     MTPObject *iter;
 
     trace_usb_mtp_op_get_object_handles(s->dev.addr, o->handle, o->path);