projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
8e16789
)
PKCS#7: fix unitialized boolean 'want'
author
Colin Ian King
<colin.king@canonical.com>
Sat, 27 Feb 2016 12:45:26 +0000
(12:45 +0000)
committer
David Howells
<dhowells@redhat.com>
Mon, 29 Feb 2016 14:29:03 +0000
(14:29 +0000)
The boolean want is not initialized and hence garbage. The default should
be false (later it is only set to true on tne sinfo->authattrs check).
Found with static analysis using CoverityScan
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David Howells <dhowells@redhat.com>
crypto/asymmetric_keys/pkcs7_parser.c
patch
|
blob
|
history
diff --git
a/crypto/asymmetric_keys/pkcs7_parser.c
b/crypto/asymmetric_keys/pkcs7_parser.c
index 3ef62dac9771db925ebbe825cd1045b406add1e0..cbbd03fd94f88702f1084521b401c46611bc8bd9 100644
(file)
--- a/
crypto/asymmetric_keys/pkcs7_parser.c
+++ b/
crypto/asymmetric_keys/pkcs7_parser.c
@@
-87,7
+87,7
@@
EXPORT_SYMBOL_GPL(pkcs7_free_message);
static int pkcs7_check_authattrs(struct pkcs7_message *msg)
{
struct pkcs7_signed_info *sinfo;
- bool want;
+ bool want
= false
;
sinfo = msg->signed_infos;
if (sinfo->authattrs) {