]> git.maquefel.me Git - brevno-suite/hugo/commitdiff
Only add root sections to the section pages menu
authorBjørn Erik Pedersen <bjorn.erik.pedersen@gmail.com>
Sat, 20 Apr 2024 14:51:56 +0000 (16:51 +0200)
committerBjørn Erik Pedersen <bjorn.erik.pedersen@gmail.com>
Sat, 20 Apr 2024 15:23:33 +0000 (17:23 +0200)
Fixes #12399

hugolib/menu_test.go
hugolib/site.go

index 816ffb6763aa0aba7264f40273570deb70db320d..9e73a8dc348bdf9d1123bbd42a947c85c1724798 100644 (file)
@@ -676,3 +676,37 @@ menu: main
        b.AssertFileContent("public/fr/index.html", `<a href="/fr/p1/">p1</a>`)
        b.AssertLogNotContains("WARN")
 }
+
+func TestSectionPagesIssue12399(t *testing.T) {
+       t.Parallel()
+
+       files := `
+-- hugo.toml --
+disableKinds = ['rss','sitemap','taxonomy','term']
+capitalizeListTitles = false
+pluralizeListTitles = false
+sectionPagesMenu = 'main'
+-- content/p1.md --
+---
+title: p1
+---
+-- content/s1/p2.md --
+---
+title: p2
+menus: main
+---
+-- content/s1/p3.md --
+---
+title: p3
+---
+-- layouts/_default/list.html --
+{{ range site.Menus.main }}<a href="{{ .URL }}">{{ .Name }}</a>{{ end }}
+-- layouts/_default/single.html --
+{{ .Title }}
+`
+
+       b := Test(t, files)
+
+       b.AssertFileExists("public/index.html", true)
+       b.AssertFileContent("public/index.html", `<a href="/s1/p2/">p2</a><a href="/s1/">s1</a>`)
+}
index b66a1284b1a66d97d4d7131e98bb137d156f20f9..2803878388d81918b0e73cf41da1c8e7ac368ce9 100644 (file)
@@ -659,7 +659,7 @@ func (s *Site) assembleMenus() error {
 
        if sectionPagesMenu != "" {
                if err := s.pageMap.forEachPage(pagePredicates.ShouldListGlobal, func(p *pageState) (bool, error) {
-                       if p.IsHome() || !p.m.shouldBeCheckedForMenuDefinitions() {
+                       if p.Kind() != kinds.KindSection || !p.m.shouldBeCheckedForMenuDefinitions() {
                                return false, nil
                        }