bcachefs: improve bch2_journal_buf_to_text()
authorKent Overstreet <kent.overstreet@linux.dev>
Sat, 17 Feb 2024 08:26:19 +0000 (03:26 -0500)
committerKent Overstreet <kent.overstreet@linux.dev>
Thu, 14 Mar 2024 01:22:25 +0000 (21:22 -0400)
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
fs/bcachefs/journal.c

index f5be8e417c8a63ddef0e6a6c8f533b9d4218e772..597733a84d38032bf6c5c8610b28c8bd0365f8e2 100644 (file)
@@ -53,33 +53,48 @@ static void bch2_journal_buf_to_text(struct printbuf *out, struct journal *j, u6
        unsigned i = seq & JOURNAL_BUF_MASK;
        struct journal_buf *buf = j->buf + i;
 
-       prt_printf(out, "seq:");
+       prt_str(out, "seq:");
        prt_tab(out);
        prt_printf(out, "%llu", seq);
        prt_newline(out);
        printbuf_indent_add(out, 2);
 
-       prt_printf(out, "refcount:");
+       prt_str(out, "refcount:");
        prt_tab(out);
        prt_printf(out, "%u", journal_state_count(s, i));
        prt_newline(out);
 
-       prt_printf(out, "size:");
+       prt_str(out, "size:");
        prt_tab(out);
        prt_human_readable_u64(out, vstruct_bytes(buf->data));
        prt_newline(out);
 
-       prt_printf(out, "expires");
+       prt_str(out, "expires:");
        prt_tab(out);
        prt_printf(out, "%li jiffies", buf->expires - jiffies);
        prt_newline(out);
 
+       prt_str(out, "flags:");
+       prt_tab(out);
+       if (buf->noflush)
+               prt_str(out, "noflush ");
+       if (buf->must_flush)
+               prt_str(out, "must_flush ");
+       if (buf->separate_flush)
+               prt_str(out, "separate_flush ");
+       if (buf->need_flush_to_write_buffer)
+               prt_str(out, "need_flush_to_write_buffer ");
+       if (buf->need_flush_to_write_buffer)
+               prt_str(out, "need_flush_to_write_buffer ");
+       if (buf->write_done)
+               prt_str(out, "write done ");
+       if (buf->write_started)
+               prt_str(out, "write started ");
+       if (buf->write_allocated)
+               prt_str(out, "write allocated ");
        if (buf->write_done)
-               prt_printf(out, "write done\n");
-       else if (buf->write_allocated)
-               prt_printf(out, "write allocated\n");
-       else if (buf->write_started)
-               prt_printf(out, "write started\n");
+               prt_str(out, "write done");
+       prt_newline(out);
 
        printbuf_indent_sub(out, 2);
 }