cpuidle: Remove redundant check in cpuidle_switch_governor()
authorYu Liao <liaoyu15@huawei.com>
Mon, 29 Aug 2022 01:15:34 +0000 (09:15 +0800)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Sat, 3 Sep 2022 18:14:51 +0000 (20:14 +0200)
gov has already been NULL checked at the beginning of
cpuidle_switch_governor, so remove redundant check.

While at it, use pr_info() instead printk() to address the following
checkpatch warning:

WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then
dev_info(dev, ... then pr_info(...  to printk(KERN_INFO ...

Signed-off-by: Yu Liao <liaoyu15@huawei.com>
[ rjw: Subject and changelog edits, added empty line after if () ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/cpuidle/governor.c

index 29acaf48e575818933c0176f576e18adefc0e5d3..0d0f9751ff8fabf400dae1779e2c8cf79285873f 100644 (file)
@@ -63,12 +63,11 @@ int cpuidle_switch_governor(struct cpuidle_governor *gov)
 
        cpuidle_curr_governor = gov;
 
-       if (gov) {
-               list_for_each_entry(dev, &cpuidle_detected_devices, device_list)
-                       cpuidle_enable_device(dev);
-               cpuidle_install_idle_handler();
-               printk(KERN_INFO "cpuidle: using governor %s\n", gov->name);
-       }
+       list_for_each_entry(dev, &cpuidle_detected_devices, device_list)
+               cpuidle_enable_device(dev);
+
+       cpuidle_install_idle_handler();
+       pr_info("cpuidle: using governor %s\n", gov->name);
 
        return 0;
 }