scsi: qlogicpti: sun_esp: Use of_property_read_bool() for boolean properties

It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property()/of_find_property() functions for reading properties.
Convert reading boolean properties to of_property_read_bool().

Signed-off-by: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20230310144723.1544999-1-robh@kernel.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/qlogicpti.c b/drivers/scsi/qlogicpti.c
index 8c961ff03fcdfe27beac2ebaafedc03c8525ca8b..bf08c7cd10ef41628c0a476d1786afd5d0e634b6 100644 (file)
--- a/drivers/scsi/qlogicpti.c
+++ b/drivers/scsi/qlogicpti.c
@@ -513,7 +513,7 @@ static int qlogicpti_load_firmware(struct qlogicpti *qpti)
                       qpti->qpti_id);
                err = 1;
                goto out;
-       }               
+       }
        sbus_writew(SBUS_CTRL_RESET, qpti->qregs + SBUS_CTRL);
        sbus_writew((DMA_CTRL_CCLEAR | DMA_CTRL_CIRQ), qpti->qregs + CMD_DMA_CTRL);
        sbus_writew((DMA_CTRL_CCLEAR | DMA_CTRL_CIRQ), qpti->qregs + DATA_DMA_CTRL);
@@ -563,7 +563,7 @@ static int qlogicpti_load_firmware(struct qlogicpti *qpti)
                       qpti->qpti_id);
                err = 1;
                goto out;
-       }               
+       }
 
        /* Load it up.. */
        for (i = 0; i < risc_code_length; i++) {
@@ -1136,7 +1136,7 @@ static struct scsi_cmnd *qlogicpti_intr_handler(struct qlogicpti *qpti)
 
        if (!(sbus_readw(qpti->qregs + SBUS_STAT) & SBUS_STAT_RINT))
                return NULL;
-               
+
        in_ptr = sbus_readw(qpti->qregs + MBOX5);
        sbus_writew(HCCTRL_CRIRQ, qpti->qregs + HCCTRL);
        if (sbus_readw(qpti->qregs + SBUS_SEMAPHORE) & SBUS_SEMAPHORE_LCK) {
@@ -1362,9 +1362,8 @@ static int qpti_sbus_probe(struct platform_device *op)
        fcode = of_get_property(dp, "isp-fcode", NULL);
        if (fcode && fcode[0])
                printk("(FCode %s)", fcode);
-       if (of_find_property(dp, "differential", NULL) != NULL)
-               qpti->differential = 1;
-                       
+       qpti->differential = of_property_read_bool(dp, "differential");
+
        printk("\nqlogicpti%d: [%s Wide, using %s interface]\n",
                qpti->qpti_id,
                (qpti->ultra ? "Ultra" : "Fast"),

diff --git a/drivers/scsi/sun_esp.c b/drivers/scsi/sun_esp.c
index 5dc38d35745b4b237eee3affc5202f993e036a5f..58bdd71fef061fe8797c8753999e953cf99ee622 100644 (file)
--- a/drivers/scsi/sun_esp.c
+++ b/drivers/scsi/sun_esp.c
@@ -146,7 +146,7 @@ static void esp_get_differential(struct esp *esp)
        struct device_node *dp;
 
        dp = op->dev.of_node;
-       if (of_find_property(dp, "differential", NULL))
+       if (of_property_read_bool(dp, "differential"))
                esp->flags |= ESP_FLAG_DIFFERENTIAL;
        else
                esp->flags &= ~ESP_FLAG_DIFFERENTIAL;