staging: r8188eu: DYNAMIC_RF_CALIBRATION is not used
authorMartin Kaiser <martin@kaiser.cx>
Mon, 21 Mar 2022 20:30:30 +0000 (21:30 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 4 Apr 2022 05:33:46 +0000 (07:33 +0200)
Remove the DYNAMIC_RF_CALIBRATION capability. It's cleared in one place
but never checked.

DYNAMIC_RF_CALIBRATION is part of podmpriv->SupportAbility, there are no
users that check SupportAbility as a whole and use DYNAMIC_RF_CALIBRATION
implicitly.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20220321203031.143486-6-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/hal/usb_halinit.c
drivers/staging/r8188eu/include/rtw_mlme_ext.h

index 599d930a59277b31bf5fce0d7254a3273b7a8b03..11dc8834acacf0350434810d9a740c1b934e1cf1 100644 (file)
@@ -1431,8 +1431,6 @@ void SetHalDefVar8188EUsb(struct adapter *Adapter, enum hal_def_variable eVariab
                                podmpriv->SupportAbility = DYNAMIC_FUNC_DISABLE;
                        } else if (dm_func == 1) {/* disable DIG */
                                podmpriv->SupportAbility  &= (~DYNAMIC_BB_DIG);
-                       } else if (dm_func == 3) {/* disable tx power tracking */
-                               podmpriv->SupportAbility  &= (~DYNAMIC_RF_CALIBRATION);
                        } else if (dm_func == 6) {/* turn on all dynamic func */
                                if (!(podmpriv->SupportAbility  & DYNAMIC_BB_DIG)) {
                                        struct rtw_dig *pDigTable = &podmpriv->DM_DigTable;
index 9b9c81fe85432106aafabbce55ec3649762881e7..9092e775fc5d38ada8cb390e732c25f165517f3c 100644 (file)
@@ -31,8 +31,6 @@
 /*  BB ODM section BIT 0-15 */
 #define        DYNAMIC_BB_DIG                          BIT(0)
 
-#define                DYNAMIC_RF_CALIBRATION          BIT(26)
-
 #define                DYNAMIC_ALL_FUNC_ENABLE         0xFFFFFFF
 
 #define _HW_STATE_NOLINK_              0x00