staging: vc04_services: bcm2835-camera: avoid the use of typedef for function pointers
authorGaston Gonzalez <gascoar@gmail.com>
Thu, 30 Dec 2021 11:31:27 +0000 (08:31 -0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 Dec 2021 13:19:53 +0000 (14:19 +0100)
Replace typedef bm2835_mmal_v4l2_ctrl_cb with equivalent declaration to
better align with the linux kernel coding style.

Signed-off-by: Gaston Gonzalez <gascoar@gmail.com>
Link: https://lore.kernel.org/r/0418e6e19e1580fff4abfc4bb2f4269dc206df44.1640776340.git.gascoar@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vc04_services/bcm2835-camera/controls.c

index b096a12387f71a460b3dd6810bec903745a5f5e5..3696dfb5a020d840dfa4f54e0514ecc1373f51e3 100644 (file)
@@ -65,13 +65,6 @@ enum bm2835_mmal_ctrl_type {
        MMAL_CONTROL_TYPE_CLUSTER, /* special cluster entry */
 };
 
-struct bm2835_mmal_v4l2_ctrl;
-
-typedef        int(bm2835_mmal_v4l2_ctrl_cb)(
-                               struct bm2835_mmal_dev *dev,
-                               struct v4l2_ctrl *ctrl,
-                               const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl);
-
 struct bm2835_mmal_v4l2_ctrl {
        u32 id; /* v4l2 control identifier */
        enum bm2835_mmal_ctrl_type type;
@@ -84,7 +77,8 @@ struct bm2835_mmal_v4l2_ctrl {
        u64 step; /* step size of the control */
        const s64 *imenu; /* integer menu array */
        u32 mmal_id; /* mmal parameter id */
-       bm2835_mmal_v4l2_ctrl_cb *setter;
+       int (*setter)(struct bm2835_mmal_dev *dev, struct v4l2_ctrl *ctrl,
+                     const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl);
 };
 
 struct v4l2_to_mmal_effects_setting {