selftests/ftrace: Have reset_ftrace_filter handle multiple instances
authorSteven Rostedt (VMware) <rostedt@goodmis.org>
Tue, 6 Feb 2018 22:15:02 +0000 (17:15 -0500)
committerSteven Rostedt (VMware) <rostedt@goodmis.org>
Thu, 8 Feb 2018 15:13:17 +0000 (10:13 -0500)
If a probe is attached to a static function that is in multiple files with
the same name, removing it by name will remove all instances:

 # grep jump_label_unlock set_ftrace_filter
jump_label_unlock:traceoff:unlimited
jump_label_unlock:traceoff:unlimited

 # echo '!jump_label_unlock:traceoff' >> set_ftrace_filter
 # grep jump_label_unlock set_ftrace_filter
 #

But the loop in reset_ftrace_filter will try to remove multiple instances
multiple times. If this happens the second time will error and cause the
test to fail.

At each iteration of the loop, check to see if the probe being removed still
exists.

Cc: Shuah Khan <shuah@kernel.org>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
tools/testing/selftests/ftrace/test.d/functions

index e7c4c7b752a2511a4d4debd53b90718c06e95444..df3dd7fe5f9b2f9a2de3fcd768fcdf5c90990fa7 100644 (file)
@@ -37,6 +37,9 @@ reset_ftrace_filter() { # reset all triggers in set_ftrace_filter
        if [ "$tr" = "" ]; then
            continue
        fi
+       if ! grep -q "$t" set_ftrace_filter; then
+               continue;
+       fi
        name=`echo $t | cut -d: -f1 | cut -d' ' -f1`
        if [ $tr = "enable_event" -o $tr = "disable_event" ]; then
            tr=`echo $t | cut -d: -f2-4`