media: uvcvideo: Do not check for V4L2_CTRL_WHICH_DEF_VAL
authorRicardo Ribalda <ribalda@chromium.org>
Fri, 18 Jun 2021 12:29:05 +0000 (14:29 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 10 Mar 2023 08:39:35 +0000 (09:39 +0100)
[ Upstream commit a2f8a484fbc96b8209a760cb3f2c95ca49c2cdb1 ]

The framework already checks for us if V4L2_CTRL_WHICH_DEF_VAL is
written.

Reviewed-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Stable-dep-of: 9f582f0418ed ("media: uvcvideo: Check for INACTIVE in uvc_ctrl_is_accessible()")
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/usb/uvc/uvc_v4l2.c

index 63842eb223a18a6f28458f9730d346a7b962beec..d2e633f6ec671eaa6b11b636e095bdce8a221411 100644 (file)
@@ -1106,10 +1106,6 @@ static int uvc_ioctl_s_try_ext_ctrls(struct uvc_fh *handle,
        unsigned int i;
        int ret;
 
-       /* Default value cannot be changed */
-       if (ctrls->which == V4L2_CTRL_WHICH_DEF_VAL)
-               return -EINVAL;
-
        ret = uvc_ctrl_begin(chain);
        if (ret < 0)
                return ret;