projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
8454f88
)
dmaengine: mv_xor_v2: Fix a resource leak in mv_xor_v2_remove()
author
Christophe JAILLET
<christophe.jaillet@wanadoo.fr>
Mon, 24 Oct 2022 19:50:09 +0000
(21:50 +0200)
committer
Vinod Koul
<vkoul@kernel.org>
Tue, 8 Nov 2022 05:13:56 +0000
(10:43 +0530)
A clk_prepare_enable() call in the probe is not balanced by a corresponding
clk_disable_unprepare() in the remove function.
Add the missing call.
Fixes: 3cd2c313f1d6 ("dmaengine: mv_xor_v2: Fix clock resource by adding a register clock")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link:
https://lore.kernel.org/r/e9e3837a680c9bd2438e4db2b83270c6c052d005.1666640987.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/mv_xor_v2.c
patch
|
blob
|
history
diff --git
a/drivers/dma/mv_xor_v2.c
b/drivers/dma/mv_xor_v2.c
index f629ef6fd3c2a5edc055751d8ab4a5fd2cc84ea6..113834e1167b6f89ec2f3d955ad274da8ad04424 100644
(file)
--- a/
drivers/dma/mv_xor_v2.c
+++ b/
drivers/dma/mv_xor_v2.c
@@
-893,6
+893,7
@@
static int mv_xor_v2_remove(struct platform_device *pdev)
tasklet_kill(&xor_dev->irq_tasklet);
clk_disable_unprepare(xor_dev->clk);
+ clk_disable_unprepare(xor_dev->reg_clk);
return 0;
}