iwlwifi: mvm: rfi: use kmemdup() to replace kzalloc + memcpy
authorBixuan Cui <cuibixuan@linux.alibaba.com>
Wed, 27 Oct 2021 06:58:40 +0000 (14:58 +0800)
committerLuca Coelho <luciano.coelho@intel.com>
Fri, 18 Feb 2022 08:40:56 +0000 (10:40 +0200)
Fix memdup.cocci warning:
./drivers/net/wireless/intel/iwlwifi/mvm/rfi.c:110:8-15: WARNING
opportunity for kmemdup

Signed-off-by: Bixuan Cui <cuibixuan@linux.alibaba.com>
Link: https://lore.kernel.org/r/1635317920-84725-1-git-send-email-cuibixuan@linux.alibaba.com
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
drivers/net/wireless/intel/iwlwifi/mvm/rfi.c

index 7acb2be08e1d47c74ce00a5d1de74bd8df618577..bb77bc9aa8218af83b21fa8b353d118b12c3685b 100644 (file)
@@ -125,12 +125,10 @@ struct iwl_rfi_freq_table_resp_cmd *iwl_rfi_get_freq_table(struct iwl_mvm *mvm)
        if (WARN_ON_ONCE(iwl_rx_packet_payload_len(cmd.resp_pkt) != resp_size))
                return ERR_PTR(-EIO);
 
-       resp = kzalloc(resp_size, GFP_KERNEL);
+       resp = kmemdup(cmd.resp_pkt->data, resp_size, GFP_KERNEL);
        if (!resp)
                return ERR_PTR(-ENOMEM);
 
-       memcpy(resp, cmd.resp_pkt->data, resp_size);
-
        iwl_free_resp(&cmd);
        return resp;
 }