staging: r8188eu: remove write-only HwRxPageSize
authorMartin Kaiser <martin@kaiser.cx>
Tue, 5 Oct 2021 20:08:15 +0000 (22:08 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 10 Oct 2021 12:55:28 +0000 (14:55 +0200)
HwRxPageSize from struct hal_data_8188e is set but never read. Remove
the component and the code to initialise it.

Acked-by: Michael Straube <straube.linux@gmail.com>
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20211005200821.19783-3-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/hal/usb_halinit.c
drivers/staging/r8188eu/include/rtl8188e_hal.h
drivers/staging/r8188eu/include/rtl8188e_spec.h

index ab7b801444035bb43c6a6a98301dd9acb16939aa..f71f25e234abd50db93092d0f049ec488de94342 100644 (file)
@@ -524,26 +524,6 @@ usb_AggSettingRxUpdate(
                /*  TODO: */
                break;
        }
-
-       switch (PBP_128) {
-       case PBP_128:
-               haldata->HwRxPageSize = 128;
-               break;
-       case PBP_64:
-               haldata->HwRxPageSize = 64;
-               break;
-       case PBP_256:
-               haldata->HwRxPageSize = 256;
-               break;
-       case PBP_512:
-               haldata->HwRxPageSize = 512;
-               break;
-       case PBP_1024:
-               haldata->HwRxPageSize = 1024;
-               break;
-       default:
-               break;
-       }
 }      /*  usb_AggSettingRxUpdate */
 
 static void InitUsbAggregationSetting(struct adapter *Adapter)
index 08dedf4c91b832d3eb6b12b767c7dcc8c3740efd..fc6acbba17e77412aa59c3db95b08c9cb8066aee 100644 (file)
@@ -360,7 +360,6 @@ struct hal_data_8188e {
        u8      C2hArray[16];
        u8      UsbTxAggMode;
        u8      UsbTxAggDescNum;
-       u16     HwRxPageSize;           /*  Hardware setting */
        u32     MaxUsbRxAggBlock;
 
        enum usb_rx_agg_mode UsbRxAggMode;
index 1c96f7b81245e7e75a56986ae48dae5ecf3b52f4..01aeaa4ac605a892d12f10236495227c4e047845 100644 (file)
@@ -893,11 +893,7 @@ Current IOREG MAP
 #define _PSRX(x)                       (x)
 #define _PSTX(x)                       ((x) << 4)
 
-#define PBP_64                         0x0
 #define PBP_128                                0x1
-#define PBP_256                                0x2
-#define PBP_512                                0x3
-#define PBP_1024                       0x4
 
 /* 2 TX/RXDMA */
 #define RXDMA_ARBBW_EN                 BIT(0)