wifi: iwlwifi: mvm: fix netif csum flags
authorJohannes Berg <johannes.berg@intel.com>
Tue, 17 Oct 2023 09:16:41 +0000 (12:16 +0300)
committerJohannes Berg <johannes.berg@intel.com>
Mon, 23 Oct 2023 10:48:28 +0000 (12:48 +0200)
We shouldn't advertise arbitrary checksum flags since we had
to remove support for it due to broken hardware.

Fixes: ec18e7d4d20d ("wifi: iwlwifi: mvm: use old checksum for Bz A-step")
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Gregory Greenman <gregory.greenman@intel.com>
Link: https://lore.kernel.org/r/20231017115047.e37327f1a129.Iaee86b00db4db791cd90adaf15384b8c87d2ad49@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/net/wireless/intel/iwlwifi/cfg/bz.c
drivers/net/wireless/intel/iwlwifi/cfg/sc.c
drivers/net/wireless/intel/iwlwifi/iwl-config.h

index b2ebc81464654b913172e01b8399252694ae1340..ed097dd394c92ca018c182f8718b33f60b4af4a6 100644 (file)
@@ -158,7 +158,7 @@ const struct iwl_cfg iwl_cfg_bz = {
        .fw_name_mac = "bz",
        .uhb_supported = true,
        IWL_DEVICE_BZ,
-       .features = IWL_TX_CSUM_NETIF_FLAGS_BZ | NETIF_F_RXCSUM,
+       .features = IWL_TX_CSUM_NETIF_FLAGS | NETIF_F_RXCSUM,
        .num_rbds = IWL_NUM_RBDS_BZ_EHT,
 };
 
@@ -166,7 +166,7 @@ const struct iwl_cfg iwl_cfg_gl = {
        .fw_name_mac = "gl",
        .uhb_supported = true,
        IWL_DEVICE_BZ,
-       .features = IWL_TX_CSUM_NETIF_FLAGS_BZ | NETIF_F_RXCSUM,
+       .features = IWL_TX_CSUM_NETIF_FLAGS | NETIF_F_RXCSUM,
        .num_rbds = IWL_NUM_RBDS_BZ_EHT,
 };
 
index fea4551ea86a6b72b36f0e9f3742c84da7f6c9ef..bc1e75ee946a69959d1be038cce92c3481a995f7 100644 (file)
@@ -151,7 +151,7 @@ const struct iwl_cfg iwl_cfg_sc = {
        .fw_name_mac = "sc",
        .uhb_supported = true,
        IWL_DEVICE_SC,
-       .features = IWL_TX_CSUM_NETIF_FLAGS_BZ | NETIF_F_RXCSUM,
+       .features = IWL_TX_CSUM_NETIF_FLAGS | NETIF_F_RXCSUM,
        .num_rbds = IWL_NUM_RBDS_SC_EHT,
 };
 
index 90bebdf85c066b249917f4b2decb33755577f0ff..02ded22295c1cebbc529275579700a7aeb7c59b9 100644 (file)
@@ -86,10 +86,7 @@ enum iwl_nvm_type {
 #define IWL_DEFAULT_MAX_TX_POWER 22
 #define IWL_TX_CSUM_NETIF_FLAGS (NETIF_F_IPV6_CSUM | NETIF_F_IP_CSUM |\
                                 NETIF_F_TSO | NETIF_F_TSO6)
-#define IWL_TX_CSUM_NETIF_FLAGS_BZ (NETIF_F_HW_CSUM | NETIF_F_TSO | NETIF_F_TSO6)
-#define IWL_CSUM_NETIF_FLAGS_MASK (IWL_TX_CSUM_NETIF_FLAGS | \
-                                  IWL_TX_CSUM_NETIF_FLAGS_BZ | \
-                                  NETIF_F_RXCSUM)
+#define IWL_CSUM_NETIF_FLAGS_MASK (IWL_TX_CSUM_NETIF_FLAGS | NETIF_F_RXCSUM)
 
 /* Antenna presence definitions */
 #define        ANT_NONE        0x0