leds: qcom-lpg: Annotate struct lpg_led with __counted_by
authorKees Cook <keescook@chromium.org>
Fri, 15 Sep 2023 20:11:00 +0000 (13:11 -0700)
committerLee Jones <lee@kernel.org>
Wed, 1 Nov 2023 11:28:32 +0000 (11:28 +0000)
Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
(for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).

As found with Coccinelle[1], add __counted_by for struct lpg_led.

[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci

Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Link: https://lore.kernel.org/r/20230915201059.never.086-kees@kernel.org
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/leds/rgb/leds-qcom-lpg.c

index df469aaa7e6e7ecf00d4be99f736c8da5fd262f4..7d93e02a030a25d6f7cb5985ddb0699a47613cc9 100644 (file)
@@ -173,7 +173,7 @@ struct lpg_led {
        struct led_classdev_mc mcdev;
 
        unsigned int num_channels;
-       struct lpg_channel *channels[];
+       struct lpg_channel *channels[] __counted_by(num_channels);
 };
 
 /**