ne2000: use inline net_crc32() and bitshift instead of compute_mcast_idx()
authorMark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Fri, 15 Dec 2017 18:41:53 +0000 (18:41 +0000)
committerJason Wang <jasowang@redhat.com>
Fri, 22 Dec 2017 02:01:27 +0000 (10:01 +0800)
This makes it much easier to compare the multicast CRC calculation endian and
bitshift against the Linux driver implementation.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: Jason Wang <jasowang@redhat.com>
hw/net/ne2000.c

index 6874c8c6b9dbbf8b5d4cb8250f67c712e2fb5896..687ef84aaca79162f66ed5730f45b8f662041ed9 100644 (file)
@@ -23,6 +23,8 @@
  */
 #include "qemu/osdep.h"
 #include "hw/pci/pci.h"
+#include "net/net.h"
+#include "net/eth.h"
 #include "ne2000.h"
 #include "hw/loader.h"
 #include "sysemu/sysemu.h"
@@ -199,7 +201,7 @@ ssize_t ne2000_receive(NetClientState *nc, const uint8_t *buf, size_t size_)
             /* multicast */
             if (!(s->rxcr & 0x08))
                 return size;
-            mcast_idx = compute_mcast_idx(buf);
+            mcast_idx = net_crc32(buf, ETH_ALEN) >> 26;
             if (!(s->mult[mcast_idx >> 3] & (1 << (mcast_idx & 7))))
                 return size;
         } else if (s->mem[0] == buf[0] &&