smb: client: fix potential UAF in cifs_stats_proc_show()
authorPaulo Alcantara <pc@manguebit.com>
Tue, 2 Apr 2024 19:33:56 +0000 (16:33 -0300)
committerSteve French <stfrench@microsoft.com>
Wed, 3 Apr 2024 19:43:45 +0000 (14:43 -0500)
Skip sessions that are being teared down (status == SES_EXITING) to
avoid UAF.

Cc: stable@vger.kernel.org
Signed-off-by: Paulo Alcantara (Red Hat) <pc@manguebit.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/client/cifs_debug.c

index 8535c990746260b24845a5da8ae484f87402602d..c71ae5c043060ebf5dd7f6d9e5f63e6e7bcf7841 100644 (file)
@@ -759,6 +759,8 @@ static int cifs_stats_proc_show(struct seq_file *m, void *v)
                        }
 #endif /* STATS2 */
                list_for_each_entry(ses, &server->smb_ses_list, smb_ses_list) {
+                       if (cifs_ses_exiting(ses))
+                               continue;
                        list_for_each_entry(tcon, &ses->tcon_list, tcon_list) {
                                i++;
                                seq_printf(m, "\n%d) %s", i, tcon->tree_name);