cifs: missing null check for newinode pointer

in cifs_do_create we check if newinode is valid before referencing it
but are missing the check in one place in fs/cifs/dir.c

Addresses-Coverity: 1357292 ("Dereference after null check")
Acked-by: Sachin Prabhu <sprabhu@redhat.com>
Signed-off-by: Steve French <stfrench@microsoft.com>

diff --git a/fs/cifs/dir.c b/fs/cifs/dir.c
index 912333082b181d8e5ff19b80e83f3282ce7a7aa7..79402ca0ddfab6735ac366fad8872cb6a88d455b 100644 (file)
--- a/fs/cifs/dir.c
+++ b/fs/cifs/dir.c
@@ -384,10 +384,11 @@ cifs_create_set_dentry:
                goto out_err;
        }
 
-       if (S_ISDIR(newinode->i_mode)) {
-               rc = -EISDIR;
-               goto out_err;
-       }
+       if (newinode)
+               if (S_ISDIR(newinode->i_mode)) {
+                       rc = -EISDIR;
+                       goto out_err;
+               }
 
        d_drop(direntry);
        d_add(direntry, newinode);