pinctrl: pinmux: Drop duplicate error message in pinmux_select()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 9 Jan 2023 13:27:19 +0000 (15:27 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 10 Jan 2023 08:03:27 +0000 (09:03 +0100)
pinctrl_get_group_selector() prints an error message when group
is not found in the list. No need to repeat this in the caller.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20230109132719.86009-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinmux.c

index 6bd7ac37a0e0ea05773a911cdec1301345c14647..021382632608063c30dcec2343d9fe796c1395b0 100644 (file)
@@ -744,10 +744,8 @@ static ssize_t pinmux_select(struct file *file, const char __user *user_buf,
        }
 
        ret = pinctrl_get_group_selector(pctldev, gname);
-       if (ret < 0) {
-               dev_err(pctldev->dev, "failed to get group selector for %s", gname);
+       if (ret < 0)
                goto exit_free_buf;
-       }
        gsel = ret;
 
        ret = pmxops->set_mux(pctldev, fsel, gsel);