serial: 8250_dw: Re-use temporary variable for of_node
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tue, 5 Oct 2021 13:45:28 +0000 (16:45 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 10 Oct 2021 13:22:06 +0000 (15:22 +0200)
In couple of places we may re-use temporary variable instead of
dereferencing it. No functional changes intended.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20211005134529.23256-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_dw.c

index 49559731bbcf1cf595fef5b787d528afa513889c..cc91cb0ce08fff8fa18b7e442428590caec3a503 100644 (file)
@@ -393,8 +393,9 @@ static bool dw8250_idma_filter(struct dma_chan *chan, void *param)
 
 static void dw8250_quirks(struct uart_port *p, struct dw8250_data *data)
 {
-       if (p->dev->of_node) {
-               struct device_node *np = p->dev->of_node;
+       struct device_node *np = p->dev->of_node;
+
+       if (np) {
                int id;
 
                /* get index of serial line, if found in DT aliases */
@@ -411,11 +412,13 @@ static void dw8250_quirks(struct uart_port *p, struct dw8250_data *data)
                        data->skip_autocfg = true;
                }
 #endif
-               if (of_device_is_big_endian(p->dev->of_node)) {
+
+               if (of_device_is_big_endian(np)) {
                        p->iotype = UPIO_MEM32BE;
                        p->serial_in = dw8250_serial_in32be;
                        p->serial_out = dw8250_serial_out32be;
                }
+
                if (of_device_is_compatible(np, "marvell,armada-38x-uart"))
                        p->serial_out = dw8250_serial_out38x;