KVM: arm64: vgic: Remove duplicate check in update_affinity_collection()

The 'coll' parameter to update_affinity_collection() is never NULL,
so comparing it with 'ite->collection' is enough to cover both
the NULL case and the "another collection" case.

Remove the duplicate check in update_affinity_collection().

Signed-off-by: Gavin Shan <gshan@redhat.com>
[maz: repainted commit message]
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20220923065447.323445-1-gshan@redhat.com

diff --git a/arch/arm64/kvm/vgic/vgic-its.c b/arch/arm64/kvm/vgic/vgic-its.c
index 9d3299a70242399e18b09585e1c7a0936d04f6a2..24d7778d1ce63fd64315e545c1bb32e0a92a007c 100644 (file)
--- a/arch/arm64/kvm/vgic/vgic-its.c
+++ b/arch/arm64/kvm/vgic/vgic-its.c
@@ -406,7 +406,7 @@ static void update_affinity_collection(struct kvm *kvm, struct vgic_its *its,
        struct its_ite *ite;
 
        for_each_lpi_its(device, ite, its) {
-               if (!ite->collection || coll != ite->collection)
+               if (ite->collection != coll)
                        continue;
 
                update_affinity_ite(kvm, ite);