s390/qeth: improve trace entries for MAC address (un)registration
authorJulian Wiedmann <jwi@linux.ibm.com>
Mon, 25 Oct 2021 09:56:50 +0000 (11:56 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 25 Oct 2021 12:58:19 +0000 (13:58 +0100)
Add the failed MAC address into the trace message. Also fix up one
format string to use %x instead of %u for the CARD_DEVID.

Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Reviewed-by: Alexandra Winter <wintera@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/s390/net/qeth_l2_main.c

index 5b6187f2d9d60a8b5ce6bad547a4e18e2441a6c5..07104fe63df49e966a67383d3003f3ee9b4f9681 100644 (file)
@@ -121,11 +121,11 @@ static int qeth_l2_write_mac(struct qeth_card *card, u8 *mac)
        QETH_CARD_TEXT(card, 2, "L2Wmac");
        rc = qeth_l2_send_setdelmac(card, mac, cmd);
        if (rc == -EADDRINUSE)
-               QETH_DBF_MESSAGE(2, "MAC already registered on device %x\n",
-                                CARD_DEVID(card));
+               QETH_DBF_MESSAGE(2, "MAC address %012llx is already registered on device %x\n",
+                                ether_addr_to_u64(mac), CARD_DEVID(card));
        else if (rc)
-               QETH_DBF_MESSAGE(2, "Failed to register MAC on device %x: %d\n",
-                                CARD_DEVID(card), rc);
+               QETH_DBF_MESSAGE(2, "Failed to register MAC address %012llx on device %x: %d\n",
+                                ether_addr_to_u64(mac), CARD_DEVID(card), rc);
        return rc;
 }
 
@@ -138,8 +138,8 @@ static int qeth_l2_remove_mac(struct qeth_card *card, u8 *mac)
        QETH_CARD_TEXT(card, 2, "L2Rmac");
        rc = qeth_l2_send_setdelmac(card, mac, cmd);
        if (rc)
-               QETH_DBF_MESSAGE(2, "Failed to delete MAC on device %u: %d\n",
-                                CARD_DEVID(card), rc);
+               QETH_DBF_MESSAGE(2, "Failed to delete MAC address %012llx on device %x: %d\n",
+                                ether_addr_to_u64(mac), CARD_DEVID(card), rc);
        return rc;
 }