build: fix "make check" without earlier "make"
authorPaolo Bonzini <pbonzini@redhat.com>
Wed, 6 Oct 2021 08:18:27 +0000 (04:18 -0400)
committerPaolo Bonzini <pbonzini@redhat.com>
Wed, 13 Oct 2021 08:47:22 +0000 (10:47 +0200)
"make check", if not preceded by "make", will not build the tools
needed by qemu-iotests.  This happens because qemu-iotests, aka
"make check-block", is not yet part of meson.build.

While at it, remove the reference to the now-dead QEMU_IOTESTS_HELPERS-y
variable.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
tests/Makefile.include

index cc1e4f2c07425f3137b0c206416e3cb2ea686ae6..8434a33fe68e8f60c97f0e1fa0d85ad25557cd5c 100644 (file)
@@ -150,14 +150,21 @@ check:
 ifeq ($(CONFIG_TOOLS)$(CONFIG_POSIX),yy)
 check: check-block
 export PYTHON
-check-block: $(SRC_PATH)/tests/check-block.sh qemu-img$(EXESUF) \
-               storage-daemon/qemu-storage-daemon$(EXESUF) \
-               qemu-io$(EXESUF) qemu-nbd$(EXESUF) $(QEMU_IOTESTS_HELPERS-y) \
-               $(filter qemu-system-%, $(ninja-targets))
+
+ifneq ($(filter check check-block check-build, $(MAKECMDGOALS)),)
+ninja-cmd-goals += \
+       qemu-img$(EXESUF) \
+       qemu-io$(EXESUF) \
+       qemu-nbd$(EXESUF) \
+       storage-daemon/qemu-storage-daemon$(EXESUF) \
+       $(filter qemu-system-%, $(ninja-targets))
+endif
+
+check-block: $(SRC_PATH)/tests/check-block.sh run-ninja
        @$<
 endif
 
-check-build: $(QEMU_IOTESTS_HELPERS-y)
+check-build: run-ninja
 
 check-clean:
        rm -rf $(TESTS_VENV_DIR) $(TESTS_RESULTS_DIR)