media: rj54n1cb0c: Don't set format in sub-device state

For the purpose of setting old non-pad based sub-device try format as a
basis for VIDIOC_TRY_FMT implementation, there is no need to set the
format in the sub-device state. Drop the assignment to the state, which
would result in a NULL pointer dereference.

Fixes: fd17e3a9a788 ("media: i2c: Use accessors for pad config 'try_*' fields")
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>

diff --git a/drivers/media/i2c/rj54n1cb0c.c b/drivers/media/i2c/rj54n1cb0c.c
index 403185b18f061f32811549c350d85eda56b4a60b..a59db10153cdcb736f66e4f1d97a091963c992a6 100644 (file)
--- a/drivers/media/i2c/rj54n1cb0c.c
+++ b/drivers/media/i2c/rj54n1cb0c.c
@@ -1008,10 +1008,8 @@ static int rj54n1_set_fmt(struct v4l2_subdev *sd,
        v4l_bound_align_image(&mf->width, 112, RJ54N1_MAX_WIDTH, align,
                              &mf->height, 84, RJ54N1_MAX_HEIGHT, align, 0);
 
-       if (format->which == V4L2_SUBDEV_FORMAT_TRY) {
-               *v4l2_subdev_state_get_format(sd_state, 0) = *mf;
+       if (format->which == V4L2_SUBDEV_FORMAT_TRY)
                return 0;
-       }
 
        /*
         * Verify if the sensor has just been powered on. TODO: replace this