scsi: qedf: Drop unnecessary NULL checks after container_of()

The result of container_of() operations is never NULL unless the embedded
element is the first element of the structure, which is not the case here.
The NULL checks are therefore unnecessary and misleading. Remove them.

The changes in this patch were made automatically using the following
Coccinelle script.

@@
type t;
identifier v;
statement s;
@@

<+...
(
  t v = container_of(...);
|
  v = container_of(...);
)
  ...
  when != v
- if (\( !v \| v == NULL \) ) s
...+>

Link: https://lore.kernel.org/r/20210510041211.2051325-1-linux@roeck-us.net
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qedf_io.c
index 4869ef813dc4ff8cdbde6d5a347248c7a178874c..6184bc4858119c2210e7b5628cba5d1e8822ded0 100644 (file)
--- a/drivers/scsi/qedf/qedf_io.c
+++ b/drivers/scsi/qedf/qedf_io.c
@@ -23,11 +23,6 @@ static void qedf_cmd_timeout(struct work_struct *work)
        struct qedf_ctx *qedf;
        struct qedf_rport *fcport;
 
-       if (io_req == NULL) {
-               QEDF_INFO(NULL, QEDF_LOG_IO, "io_req is NULL.\n");
-               return;
-       }
-
        fcport = io_req->fcport;
        if (io_req->fcport == NULL) {
                QEDF_INFO(NULL, QEDF_LOG_IO,  "fcport is NULL.\n");

diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
index 69f7784233f938ce9d6ebda1b0262da86fe49a02..9c7efdf40dd50abfb595304b5a1b3b2fddde7477 100644 (file)
--- a/drivers/scsi/qedf/qedf_main.c
+++ b/drivers/scsi/qedf/qedf_main.c
@@ -3971,10 +3971,6 @@ void qedf_stag_change_work(struct work_struct *work)
        struct qedf_ctx *qedf =
            container_of(work, struct qedf_ctx, stag_work.work);
 
-       if (!qedf) {
-               QEDF_ERR(NULL, "qedf is NULL");
-               return;
-       }
        QEDF_ERR(&qedf->dbg_ctx, "Performing software context reset.\n");
        qedf_ctx_soft_reset(qedf->lport);
 }