drm/amd/display: Don't update drm connector when read local EDID
authorWayne Lin <Wayne.Lin@amd.com>
Wed, 19 Jan 2022 08:24:43 +0000 (16:24 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 25 Jan 2022 23:00:34 +0000 (18:00 -0500)
[Why]
Currently, when we're tentatively detecting link configuration under mst
case, we will wrongly notify a none existing stream sink to drm layer.

It's due to we'll call amdgpu_dm_update_connector_after_detect() within
dm_helpers_read_local_edid() to update connector when we're still under
tentative detection procedure.

[How]
dm_helpers_read_local_edid() was designed to do "read" only. Don't
update drm connector status when we're still under detection process.

Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Signed-off-by: Wayne Lin <Wayne.Lin@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c

index b32a68a3586a5f684c1e7f9742b140a91365b147..bfeace371ac14b499939bac3844a19555acfc8ad 100644 (file)
@@ -648,14 +648,6 @@ enum dc_edid_status dm_helpers_read_local_edid(
                /* We don't need the original edid anymore */
                kfree(edid);
 
-               /* connector->display_info is parsed from EDID and saved
-                * into drm_connector->display_info
-                *
-                * drm_connector->display_info will be used by amdgpu_dm funcs,
-                * like fill_stream_properties_from_drm_display_mode
-                */
-               amdgpu_dm_update_connector_after_detect(aconnector);
-
                edid_status = dm_helpers_parse_edid_caps(
                                                link,
                                                &sink->dc_edid,