mediatek: mt76: mac80211: Fix missing of_node_put() in mt76_led_init()
authorLiang He <windhl@126.com>
Mon, 4 Jul 2022 08:34:20 +0000 (16:34 +0800)
committerFelix Fietkau <nbd@nbd.name>
Mon, 11 Jul 2022 11:40:03 +0000 (13:40 +0200)
We should use of_node_put() for the reference 'np' returned by
of_get_child_by_name() which will increase the refcount.

Fixes: 17f1de56df05 ("mt76: add common code shared between multiple chipsets")
Signed-off-by: Liang He <windhl@126.com>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
drivers/net/wireless/mediatek/mt76/mac80211.c

index 0e7bd4a67ad454b5868632cf8f5c9bac7f6ea359..253cbc1956d19953ca16dd10b154cf5d5b64c34e 100644 (file)
@@ -216,6 +216,7 @@ static int mt76_led_init(struct mt76_dev *dev)
                if (!of_property_read_u32(np, "led-sources", &led_pin))
                        dev->led_pin = led_pin;
                dev->led_al = of_property_read_bool(np, "led-active-low");
+               of_node_put(np);
        }
 
        return led_classdev_register(dev->dev, &dev->led_cdev);