qemu-config: Use ERRP_GUARD() where obviously appropriate
authorMarkus Armbruster <armbru@redhat.com>
Mon, 21 Nov 2022 08:50:51 +0000 (09:50 +0100)
committerMarkus Armbruster <armbru@redhat.com>
Wed, 14 Dec 2022 15:19:35 +0000 (16:19 +0100)
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20221121085054.683122-8-armbru@redhat.com>

util/qemu-config.c

index e983607b46b2eea5db8d664dcaca3257ac94e339..8c907fa83b65f05201f0ec42e2cc6aa215da586d 100644 (file)
@@ -318,9 +318,9 @@ void qemu_add_opts(QemuOptsList *list)
 static int qemu_config_foreach(FILE *fp, QEMUConfigCB *cb, void *opaque,
                                const char *fname, Error **errp)
 {
+    ERRP_GUARD();
     char line[1024], prev_group[64], group[64], arg[64], value[1024];
     Location loc;
-    Error *local_err = NULL;
     QDict *qdict = NULL;
     int res = -EINVAL, lno = 0;
     int count = 0;
@@ -348,10 +348,9 @@ static int qemu_config_foreach(FILE *fp, QEMUConfigCB *cb, void *opaque,
             }
             if (qdict != prev) {
                 if (prev) {
-                    cb(prev_group, prev, opaque, &local_err);
+                    cb(prev_group, prev, opaque, errp);
                     qobject_unref(prev);
-                    if (local_err) {
-                        error_propagate(errp, local_err);
+                    if (*errp) {
                         goto out;
                     }
                 }