RDMA/irdma: Ensure iWarp QP queue memory is OS paged aligned
authorMike Marciniszyn <mike.marciniszyn@intel.com>
Wed, 29 Nov 2023 20:21:42 +0000 (14:21 -0600)
committerJason Gunthorpe <jgg@nvidia.com>
Tue, 5 Dec 2023 00:02:41 +0000 (20:02 -0400)
The SQ is shared for between kernel and used by storing the kernel page
pointer and passing that to a kmap_atomic().

This then requires that the alignment is PAGE_SIZE aligned.

Fix by adding an iWarp specific alignment check.

Fixes: e965ef0e7b2c ("RDMA/irdma: Split QP handler into irdma_reg_user_mr_type_qp")
Link: https://lore.kernel.org/r/20231129202143.1434-3-shiraz.saleem@intel.com
Signed-off-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Signed-off-by: Shiraz Saleem <shiraz.saleem@intel.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/infiniband/hw/irdma/verbs.c

index 5fa88e6cca4e907c83ffbe8f076266812a9baf0f..fb9088392b1994d4367ae8d4a0bcafcc3cb48f99 100644 (file)
@@ -2946,6 +2946,11 @@ static int irdma_reg_user_mr_type_qp(struct irdma_mem_reg_req req,
        int err;
        u8 lvl;
 
+       /* iWarp: Catch page not starting on OS page boundary */
+       if (!rdma_protocol_roce(&iwdev->ibdev, 1) &&
+           ib_umem_offset(iwmr->region))
+               return -EINVAL;
+
        total = req.sq_pages + req.rq_pages + 1;
        if (total > iwmr->page_cnt)
                return -EINVAL;