ASoC: Intel: avs: Keep module refcount up when gathering traces
authorCezary Rojewski <cezary.rojewski@intel.com>
Fri, 29 Sep 2023 11:24:34 +0000 (13:24 +0200)
committerMark Brown <broonie@kernel.org>
Fri, 29 Sep 2023 12:17:54 +0000 (14:17 +0200)
To prevent rmmod and similar behave unexpectedly when invoked on
snd_soc_avs module while the AudioDSP firmware tracing is ongoing,
increase the module refcount until the tracing is stopped.

Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Link: https://lore.kernel.org/r/20230929112436.787058-5-amadeuszx.slawinski@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/avs/debugfs.c

index bdd388ec01eaf76609ca9d979f9d83980406242f..4dfbff0ce5083b0128cfe0127e548d9d171c0359 100644 (file)
@@ -236,6 +236,9 @@ static int strace_open(struct inode *inode, struct file *file)
        struct avs_dev *adev = inode->i_private;
        int ret;
 
+       if (!try_module_get(adev->dev->driver->owner))
+               return -ENODEV;
+
        if (kfifo_initialized(&adev->trace_fifo))
                return -EBUSY;
 
@@ -270,6 +273,7 @@ static int strace_release(struct inode *inode, struct file *file)
 
        spin_unlock_irqrestore(&adev->trace_lock, flags);
 
+       module_put(adev->dev->driver->owner);
        return 0;
 }