printk: For @suppress_panic_printk check for other CPU in panic
authorJohn Ogness <john.ogness@linutronix.de>
Wed, 7 Feb 2024 13:40:55 +0000 (14:46 +0106)
committerPetr Mladek <pmladek@suse.com>
Wed, 7 Feb 2024 16:23:18 +0000 (17:23 +0100)
Currently @suppress_panic_printk is checked along with
non-matching @panic_cpu and current CPU. This works
because @suppress_panic_printk is only set when
panic_in_progress() is true.

Rather than relying on the @suppress_panic_printk semantics,
use the concise helper function other_cpu_in_progress(). The
helper function exists to avoid open coding such tests.

Signed-off-by: John Ogness <john.ogness@linutronix.de>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Link: https://lore.kernel.org/r/20240207134103.1357162-7-john.ogness@linutronix.de
Signed-off-by: Petr Mladek <pmladek@suse.com>
kernel/printk/printk.c

index be95a6851164793aa707c2c432f7eff363958ebe..22bb45d8f2f210357c26824812a81b6c576508bb 100644 (file)
@@ -2270,8 +2270,7 @@ asmlinkage int vprintk_emit(int facility, int level,
        if (unlikely(suppress_printk))
                return 0;
 
-       if (unlikely(suppress_panic_printk) &&
-           atomic_read(&panic_cpu) != raw_smp_processor_id())
+       if (unlikely(suppress_panic_printk) && other_cpu_in_panic())
                return 0;
 
        if (level == LOGLEVEL_SCHED) {