arm64: dts: rockchip: enable internal pull-up for Q7_THRM# on RK3399 Puma
authorIskander Amara <iskander.amara@theobroma-systems.com>
Fri, 8 Mar 2024 08:52:42 +0000 (09:52 +0100)
committerHeiko Stuebner <heiko@sntech.de>
Sun, 24 Mar 2024 22:21:45 +0000 (23:21 +0100)
Q7_THRM# pin is connected to a diode on the module which is used
as a level shifter, and the pin have a pull-down enabled by
default. We need to configure it to internal pull-up, other-
wise whenever the pin is configured as INPUT and we try to
control it externally the value will always remain zero.

Signed-off-by: Iskander Amara <iskander.amara@theobroma-systems.com>
Fixes: 2c66fc34e945 ("arm64: dts: rockchip: add RK3399-Q7 (Puma) SoM")
Reviewed-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20240308085243.69903-1-iskander.amara@theobroma-systems.com
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi

index c08e69391c015405a5ea7de34e211ee12ee6c58a..06f3e97af7cd7145da504bcd309d340f6f72934d 100644 (file)
 };
 
 &pinctrl {
+       pinctrl-names = "default";
+       pinctrl-0 = <&q7_thermal_pin>;
+
+       gpios {
+               q7_thermal_pin: q7-thermal-pin {
+                       rockchip,pins =
+                               <0 RK_PA3 RK_FUNC_GPIO &pcfg_pull_up>;
+               };
+       };
+
        i2c8 {
                i2c8_xfer_a: i2c8-xfer {
                        rockchip,pins =