staging: rtl8723bs: remove RT_TRACE logs in core/rtw_mlme_ext.c

Remove all of the RT_TRACE logs in the core/rtw_mlme_ext.c file as they
currently do nothing as they require the code to be modified by
hand in order to be turned on. This obviously has not happened
since the code was merged. Moreover it relies on an unneeded
private log level tracing which overrides the in-kernel public one,
so just remove them as they are unused.

Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/4f838d1ce3cd16fab8f05d1e0f80c2e7469701b8.1617545239.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
index 8aadcf72a7ba5001e8ad053a78e63af70d486035..9855a77a51884b7d3d97f850478d097ea2bc44ea 100644 (file)
--- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
@@ -526,14 +526,8 @@ void mgt_dispatcher(struct adapter *padapter, union recv_frame *precv_frame)
        struct dvobj_priv *psdpriv = padapter->dvobj;
        struct debug_priv *pdbgpriv = &psdpriv->drv_dbg;
 
-       RT_TRACE(_module_rtl871x_mlme_c_, _drv_info_,
-                ("+mgt_dispatcher: type(0x%x) subtype(0x%x)\n",
-                 GetFrameType(pframe), GetFrameSubType(pframe)));
-
-       if (GetFrameType(pframe) != WIFI_MGT_TYPE) {
-               RT_TRACE(_module_rtl871x_mlme_c_, _drv_err_, ("mgt_dispatcher: type(0x%x) error!\n", GetFrameType(pframe)));
+       if (GetFrameType(pframe) != WIFI_MGT_TYPE)
                return;
-       }
 
        /* receive the frames that ra(a1) is my address or ra(a1) is bc address. */
        if (memcmp(GetAddr1Ptr(pframe), myid(&padapter->eeprompriv), ETH_ALEN) &&
@@ -545,10 +539,9 @@ void mgt_dispatcher(struct adapter *padapter, union recv_frame *precv_frame)
 
        index = GetFrameSubType(pframe) >> 4;
 
-       if (index >= ARRAY_SIZE(mlme_sta_tbl)) {
-               RT_TRACE(_module_rtl871x_mlme_c_, _drv_err_, ("Currently we do not support reserved sub-fr-type =%d\n", index));
+       if (index >= ARRAY_SIZE(mlme_sta_tbl))
                return;
-       }
+
        ptable += index;
 
        if (psta) {
@@ -2675,8 +2668,6 @@ static int _issue_probereq(struct adapter *padapter,
        int     bssrate_len = 0;
        u8 bc_addr[] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff};
 
-       RT_TRACE(_module_rtl871x_mlme_c_, _drv_notice_, ("+issue_probereq\n"));
-
        pmgntframe = alloc_mgtxmitframe(pxmitpriv);
        if (!pmgntframe)
                goto exit;
@@ -2743,8 +2734,6 @@ static int _issue_probereq(struct adapter *padapter,
 
        pattrib->last_txcmdsz = pattrib->pktlen;
 
-       RT_TRACE(_module_rtl871x_mlme_c_, _drv_notice_, ("issuing probe_req, tx_len =%d\n", pattrib->last_txcmdsz));
-
        if (wait_ack) {
                ret = dump_mgntframe_and_wait_ack(padapter, pmgntframe);
        } else {
@@ -4441,8 +4430,6 @@ void start_create_ibss(struct adapter *padapter)
 
                /* issue beacon */
                if (send_beacon(padapter) == _FAIL) {
-                       RT_TRACE(_module_rtl871x_mlme_c_, _drv_err_, ("issuing beacon frame fail....\n"));
-
                        report_join_res(padapter, -1);
                        pmlmeinfo->state = WIFI_FW_NULL_STATE;
                } else {
@@ -4622,8 +4609,6 @@ static void process_80211d(struct adapter *padapter, struct wlan_bssid_ex *bssid
                memset(country, 0, 4);
                memcpy(country, p, 3);
                p += 3;
-               RT_TRACE(_module_rtl871x_mlme_c_, _drv_notice_,
-                               ("%s: 802.11d country =%s\n", __func__, country));
 
                i = 0;
                while ((ie - p) >= 3) {
@@ -4813,9 +4798,6 @@ static void process_80211d(struct adapter *padapter, struct wlan_bssid_ex *bssid
                                        break;
 
                                chplan_new[i].ScanType = SCAN_ACTIVE;
-                               RT_TRACE(_module_rtl871x_mlme_c_, _drv_notice_,
-                                                ("%s: change channel %d scan type from passive to active\n",
-                                                 __func__, channel));
                        }
                        break;
                }
@@ -6332,10 +6314,6 @@ u8 mlme_evt_hdl(struct adapter *padapter, unsigned char *pbuf)
        #ifdef CHECK_EVENT_SEQ
        /*  checking event sequence... */
        if (evt_seq != (atomic_read(&pevt_priv->event_seq) & 0x7f)) {
-               RT_TRACE(_module_rtl871x_cmd_c_, _drv_info_,
-                        ("Event Seq Error! %d vs %d\n", (evt_seq & 0x7f),
-                         (atomic_read(&pevt_priv->event_seq) & 0x7f)));
-
                pevt_priv->event_seq = (evt_seq+1)&0x7f;
 
                goto _abort_event_;
@@ -6343,21 +6321,14 @@ u8 mlme_evt_hdl(struct adapter *padapter, unsigned char *pbuf)
        #endif
 
        /*  checking if event code is valid */
-       if (evt_code >= MAX_C2HEVT) {
-               RT_TRACE(_module_rtl871x_cmd_c_, _drv_err_, ("\nEvent Code(%d) mismatch!\n", evt_code));
+       if (evt_code >= MAX_C2HEVT)
                goto _abort_event_;
-       }
 
        /*  checking if event size match the event parm size */
        if ((wlanevents[evt_code].parmsize != 0) &&
-                       (wlanevents[evt_code].parmsize != evt_sz)) {
-
-               RT_TRACE(_module_rtl871x_cmd_c_, _drv_err_, ("\nEvent(%d) Parm Size mismatch (%d vs %d)!\n",
-                       evt_code, wlanevents[evt_code].parmsize, evt_sz));
+                       (wlanevents[evt_code].parmsize != evt_sz))
                goto _abort_event_;
 
-       }
-
        atomic_inc(&pevt_priv->event_seq);
 
        peventbuf += 2;