iomap: Use iomap_punch_t typedef
authorRitesh Harjani (IBM) <ritesh.list@gmail.com>
Mon, 10 Jul 2023 21:12:23 +0000 (14:12 -0700)
committerRitesh Harjani (IBM) <ritesh.list@gmail.com>
Tue, 25 Jul 2023 05:25:55 +0000 (10:55 +0530)
It makes it much easier if we have iomap_punch_t typedef for "punch"
function pointer in all delalloc related punch, scan and release
functions. It will be useful in later patches when we will factor out
iomap_write_delalloc_punch() function.

Suggested-by: Matthew Wilcox <willy@infradead.org>
Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
fs/iomap/buffered-io.c

index 38e95302bd6ad51bcdce4c03328fc8350d0efdf0..864a2358e5d24b63702fb766f4e594e91813f190 100644 (file)
@@ -23,6 +23,7 @@
 
 #define IOEND_BATCH_SIZE       4096
 
+typedef int (*iomap_punch_t)(struct inode *inode, loff_t offset, loff_t length);
 /*
  * Structure allocated for each folio to track per-block uptodate state
  * and I/O completions.
@@ -901,7 +902,7 @@ EXPORT_SYMBOL_GPL(iomap_file_buffered_write);
  */
 static int iomap_write_delalloc_scan(struct inode *inode,
                loff_t *punch_start_byte, loff_t start_byte, loff_t end_byte,
-               int (*punch)(struct inode *inode, loff_t offset, loff_t length))
+               iomap_punch_t punch)
 {
        while (start_byte < end_byte) {
                struct folio    *folio;
@@ -979,8 +980,7 @@ static int iomap_write_delalloc_scan(struct inode *inode,
  * the code to subtle off-by-one bugs....
  */
 static int iomap_write_delalloc_release(struct inode *inode,
-               loff_t start_byte, loff_t end_byte,
-               int (*punch)(struct inode *inode, loff_t pos, loff_t length))
+               loff_t start_byte, loff_t end_byte, iomap_punch_t punch)
 {
        loff_t punch_start_byte = start_byte;
        loff_t scan_end_byte = min(i_size_read(inode), end_byte);
@@ -1073,8 +1073,7 @@ out_unlock:
  */
 int iomap_file_buffered_write_punch_delalloc(struct inode *inode,
                struct iomap *iomap, loff_t pos, loff_t length,
-               ssize_t written,
-               int (*punch)(struct inode *inode, loff_t pos, loff_t length))
+               ssize_t written, iomap_punch_t punch)
 {
        loff_t                  start_byte;
        loff_t                  end_byte;