spapr/xics: Drop unused argument to xics_kvm_has_broken_disconnect()
authorGreg Kurz <groug@kaod.org>
Fri, 20 Nov 2020 17:46:43 +0000 (18:46 +0100)
committerDavid Gibson <david@gibson.dropbear.id.au>
Mon, 14 Dec 2020 04:50:55 +0000 (15:50 +1100)
Never used from the start.

Signed-off-by: Greg Kurz <groug@kaod.org>
Message-Id: <20201120174646.619395-6-groug@kaod.org>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
hw/intc/xics_kvm.c
hw/ppc/spapr_irq.c
include/hw/ppc/xics_spapr.h

index 68bb1914b9bbbba6977de8ec83a7c5c31280896b..570d635bcc08596b1cc9cb1ab415c06b2b8af098 100644 (file)
@@ -484,7 +484,7 @@ void xics_kvm_disconnect(SpaprInterruptController *intc)
  * support destruction of a KVM XICS device while the VM is running.
  * Required to start a spapr machine with ic-mode=dual,kernel-irqchip=on.
  */
-bool xics_kvm_has_broken_disconnect(SpaprMachineState *spapr)
+bool xics_kvm_has_broken_disconnect(void)
 {
     int rc;
 
index f59960339ec3cb379f6978eb1ae30cc608bc88b9..a0d1e1298e1ea7f3c4b5e6fcd2483e61be4d33af 100644 (file)
@@ -186,7 +186,7 @@ static int spapr_irq_check(SpaprMachineState *spapr, Error **errp)
     if (kvm_enabled() &&
         spapr->irq == &spapr_irq_dual &&
         kvm_kernel_irqchip_required() &&
-        xics_kvm_has_broken_disconnect(spapr)) {
+        xics_kvm_has_broken_disconnect()) {
         error_setg(errp,
             "KVM is incompatible with ic-mode=dual,kernel-irqchip=on");
         error_append_hint(errp,
index 0b8182e40b33e07d074ba9948039f3a203e4d27c..de752c0d2c7eccb24c80e9465aa0ec634b48fcf0 100644 (file)
@@ -38,6 +38,6 @@ DECLARE_INSTANCE_CHECKER(ICSState, ICS_SPAPR,
 int xics_kvm_connect(SpaprInterruptController *intc, uint32_t nr_servers,
                      Error **errp);
 void xics_kvm_disconnect(SpaprInterruptController *intc);
-bool xics_kvm_has_broken_disconnect(SpaprMachineState *spapr);
+bool xics_kvm_has_broken_disconnect(void);
 
 #endif /* XICS_SPAPR_H */