projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
b645e57
)
net/mlx5e: Fix wrong return value on ioctl EEPROM query failure
author
Gal Pressman
<gal@nvidia.com>
Wed, 2 Feb 2022 14:07:21 +0000
(16:07 +0200)
committer
Saeed Mahameed
<saeedm@nvidia.com>
Thu, 24 Feb 2022 00:08:15 +0000
(16:08 -0800)
The ioctl EEPROM query wrongly returns success on read failures, fix
that by returning the appropriate error code.
Fixes: bb64143eee8c ("net/mlx5e: Add ethtool support for dump module EEPROM")
Signed-off-by: Gal Pressman <gal@nvidia.com>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c
patch
|
blob
|
history
diff --git
a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c
b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c
index 57d755db1cf5a92a434c6dec196e27863bfade93..6e80585d731fe7a0f8b6a2fb2fed0cca49cb93f7 100644
(file)
--- a/
drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c
+++ b/
drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c
@@
-1792,7
+1792,7
@@
static int mlx5e_get_module_eeprom(struct net_device *netdev,
if (size_read < 0) {
netdev_err(priv->netdev, "%s: mlx5_query_eeprom failed:0x%x\n",
__func__, size_read);
- return
0
;
+ return
size_read
;
}
i += size_read;