um: Implement ndelay/udelay in time-travel mode
authorJohannes Berg <johannes.berg@intel.com>
Thu, 13 Feb 2020 13:26:48 +0000 (14:26 +0100)
committerRichard Weinberger <richard@nod.at>
Sun, 29 Mar 2020 21:29:52 +0000 (23:29 +0200)
In external or inf-cpu time-travel mode, ndelay/udelay currently
just waste CPU time since the simulation time doesn't advance.
Implement them properly in this case.

Note that the "if (time_travel_mode == ...)" parts compile out
if CONFIG_UML_TIME_TRAVEL_SUPPORT isn't set, time_travel_mode is
defined to TT_MODE_OFF in that case.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
arch/um/include/asm/Kbuild
arch/um/include/asm/delay.h [new file with mode: 0644]
arch/um/include/linux/time-internal.h
arch/um/kernel/time.c

index db7d9d4e30d83b9353d0235d35018a46c999795a..8d435f8a6decdd9e8560f907958e63fb839148a4 100644 (file)
@@ -3,7 +3,6 @@ generic-y += bpf_perf_event.h
 generic-y += bug.h
 generic-y += compat.h
 generic-y += current.h
-generic-y += delay.h
 generic-y += device.h
 generic-y += emergency-restart.h
 generic-y += exec.h
diff --git a/arch/um/include/asm/delay.h b/arch/um/include/asm/delay.h
new file mode 100644 (file)
index 0000000..56fc2b8
--- /dev/null
@@ -0,0 +1,30 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+#ifndef __UM_DELAY_H
+#define __UM_DELAY_H
+#include <asm-generic/delay.h>
+#include <linux/time-internal.h>
+
+static inline void um_ndelay(unsigned long nsecs)
+{
+       if (time_travel_mode == TT_MODE_INFCPU ||
+           time_travel_mode == TT_MODE_EXTERNAL) {
+               time_travel_ndelay(nsecs);
+               return;
+       }
+       ndelay(nsecs);
+}
+#undef ndelay
+#define ndelay um_ndelay
+
+static inline void um_udelay(unsigned long usecs)
+{
+       if (time_travel_mode == TT_MODE_INFCPU ||
+           time_travel_mode == TT_MODE_EXTERNAL) {
+               time_travel_ndelay(1000 * usecs);
+               return;
+       }
+       udelay(usecs);
+}
+#undef udelay
+#define udelay um_udelay
+#endif /* __UM_DELAY_H */
index e21655926f0815cb4a9b02356dfe18128b32ada8..f3b03d39a854387e4b6544ff1297bedaa2b0f53a 100644 (file)
@@ -75,4 +75,10 @@ static inline void time_travel_wait_readable(int fd)
 {
 }
 #endif /* CONFIG_UML_TIME_TRAVEL_SUPPORT */
+
+/*
+ * Without CONFIG_UML_TIME_TRAVEL_SUPPORT this is a linker error if used,
+ * which is intentional since we really shouldn't link it in that case.
+ */
+void time_travel_ndelay(unsigned long nsec);
 #endif /* __TIMER_INTERNAL_H__ */
index 15c4825b857e166134bbb0c9f111e19547f72fe5..25eaa6a0c6583f79e10ab292fa4ac67193f105a4 100644 (file)
@@ -374,6 +374,12 @@ static void time_travel_update_time(unsigned long long next, bool idle)
        time_travel_del_event(&ne);
 }
 
+void time_travel_ndelay(unsigned long nsec)
+{
+       time_travel_update_time(time_travel_time + nsec, false);
+}
+EXPORT_SYMBOL(time_travel_ndelay);
+
 void time_travel_add_irq_event(struct time_travel_event *e)
 {
        BUG_ON(time_travel_mode != TT_MODE_EXTERNAL);