ieee802154: mrf24j40: fix incorrect mask in mrf24j40_stop
authorGustavo A. R. Silva <garsilva@embeddedor.com>
Tue, 31 Oct 2017 06:31:27 +0000 (01:31 -0500)
committerStefan Schmidt <stefan@osg.samsung.com>
Mon, 6 Nov 2017 15:27:55 +0000 (16:27 +0100)
It seems that this is a copy/paste error and the proper bit masking is:
BIT_TXNIE | BIT_RXIE

This issue was detected with the help of Coccinelle.

Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Fixes: 7d840545e5b9 ("mrf24j40: replace magic numbers")
Acked-by: Alan Ott <alan@signal11.us>
Signed-off-by: Stefan Schmidt <stefan@osg.samsung.com>
drivers/net/ieee802154/mrf24j40.c

index ee7084b2d52d323f4ba94153e8a91f5f65ad1d84..cf4788d840bf1ff9bdd206915088a0aff39938d2 100644 (file)
@@ -635,7 +635,7 @@ static void mrf24j40_stop(struct ieee802154_hw *hw)
 
        /* Set TXNIE and RXIE. Disable Interrupts */
        regmap_update_bits(devrec->regmap_short, REG_INTCON,
-                          BIT_TXNIE | BIT_TXNIE, BIT_TXNIE | BIT_TXNIE);
+                          BIT_TXNIE | BIT_RXIE, BIT_TXNIE | BIT_RXIE);
 }
 
 static int mrf24j40_set_channel(struct ieee802154_hw *hw, u8 page, u8 channel)