parport: remove non-zero check on count
authorColin Ian King <colin.king@canonical.com>
Fri, 30 Jul 2021 10:07:10 +0000 (11:07 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 27 Aug 2021 14:18:42 +0000 (16:18 +0200)
The check for count appears to be incorrect since a non-zero count
check occurs a couple of statements earlier. Currently the check is
always false and the dev->port->irq != PARPORT_IRQ_NONE part of the
check is never tested and the if statement is dead-code. Fix this
by removing the check on count.

Note that this code is pre-git history, so I can't find a sha for
it.

Acked-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Addresses-Coverity: ("Logically dead code")
Link: https://lore.kernel.org/r/20210730100710.27405-1-colin.king@canonical.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/parport/ieee1284_ops.c

index 2c11bd3fe1fd687eb8abd791af5be7f7dd9932a4..17061f1df0f441a0ac88462e5ff4691049cd4f99 100644 (file)
@@ -518,7 +518,7 @@ size_t parport_ieee1284_ecp_read_data (struct parport *port,
                                goto out;
 
                        /* Yield the port for a while. */
-                       if (count && dev->port->irq != PARPORT_IRQ_NONE) {
+                       if (dev->port->irq != PARPORT_IRQ_NONE) {
                                parport_release (dev);
                                schedule_timeout_interruptible(msecs_to_jiffies(40));
                                parport_claim_or_block (dev);