rtc: mxc_v2: Replace spin_lock_irqsave with spin_lock in hard IRQ
authorXiaofei Tan <tanxiaofei@huawei.com>
Wed, 3 Feb 2021 12:39:41 +0000 (20:39 +0800)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Fri, 5 Feb 2021 23:50:48 +0000 (00:50 +0100)
It is redundant to do irqsave and irqrestore in hardIRQ context, where
it has been in a irq-disabled context.

Signed-off-by: Xiaofei Tan <tanxiaofei@huawei.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/1612355981-6764-7-git-send-email-tanxiaofei@huawei.com
drivers/rtc/rtc-mxc_v2.c

index 0d73f6f0cf9e4721e9fc0a12175f5d0af3b2df82..a577a74aaf75a6d30843f28321dc2b7ff9826974 100644 (file)
@@ -74,13 +74,12 @@ static irqreturn_t mxc_rtc_interrupt(int irq, void *dev_id)
        struct device *dev = dev_id;
        struct mxc_rtc_data *pdata = dev_get_drvdata(dev);
        void __iomem *ioaddr = pdata->ioaddr;
-       unsigned long flags;
        u32 lp_status;
        u32 lp_cr;
 
-       spin_lock_irqsave(&pdata->lock, flags);
+       spin_lock(&pdata->lock);
        if (clk_enable(pdata->clk)) {
-               spin_unlock_irqrestore(&pdata->lock, flags);
+               spin_unlock(&pdata->lock);
                return IRQ_NONE;
        }
 
@@ -104,7 +103,7 @@ static irqreturn_t mxc_rtc_interrupt(int irq, void *dev_id)
 
        mxc_rtc_sync_lp_locked(dev, ioaddr);
        clk_disable(pdata->clk);
-       spin_unlock_irqrestore(&pdata->lock, flags);
+       spin_unlock(&pdata->lock);
        return IRQ_HANDLED;
 }