projects
/
qemu.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
09a3615
)
hw/net: cadence_gem: Fix MDIO_OP_xxx values
author
Bin Meng
<bmeng@tinylab.org>
Tue, 2 Jan 2024 14:18:03 +0000
(22:18 +0800)
committer
Michael Tokarev
<mjt@tls.msk.ru>
Fri, 5 Jan 2024 19:28:54 +0000
(22:28 +0300)
Testing upstream U-Boot with 'sifive_u' machine we see:
=> dhcp
ethernet@
10090000
: PHY present at 0
Could not get PHY for ethernet@
10090000
: addr 0
phy_connect failed
This has been working till QEMU 8.1 but broken since QEMU 8.2.
Fixes: 1b09eeb122aa ("hw/net/cadence_gem: use FIELD to describe PHYMNTNC register fields")
Reported-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Signed-off-by: Bin Meng <bmeng@tinylab.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
hw/net/cadence_gem.c
patch
|
blob
|
history
diff --git
a/hw/net/cadence_gem.c
b/hw/net/cadence_gem.c
index d7b7b134b0980a7ee66643cec52093aee036444d..ec7bf562e5763b028059384209185ac171c5c7c6 100644
(file)
--- a/
hw/net/cadence_gem.c
+++ b/
hw/net/cadence_gem.c
@@
-199,8
+199,8
@@
REG32(PHYMNTNC, 0x34) /* Phy Maintenance reg */
FIELD(PHYMNTNC, PHY_ADDR, 23, 5)
FIELD(PHYMNTNC, OP, 28, 2)
FIELD(PHYMNTNC, ST, 30, 2)
-#define MDIO_OP_READ 0x
3
-#define MDIO_OP_WRITE 0x
2
+#define MDIO_OP_READ 0x
2
+#define MDIO_OP_WRITE 0x
1
REG32(RXPAUSE, 0x38) /* RX Pause Time reg */
REG32(TXPAUSE, 0x3c) /* TX Pause Time reg */