PM / Domains: Return early for all errors in _genpd_power_off()
authorAisheng Dong <aisheng.dong@nxp.com>
Wed, 6 Mar 2019 13:25:15 +0000 (13:25 +0000)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 11 Mar 2019 10:26:45 +0000 (11:26 +0100)
It is strange to only return early for -EBUSY state and left other
errors to be still measured execution time.

As for error cases, the elapsed_ns computed actually is not quite
accurate and meaningful for governor to use. So let's simply return
for all error cases.

Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/base/power/domain.c

index 394f9daa39837eb7a334befcc20b3fd5acf7dbc8..f01257607bf7e3b19476ebe99339d63e4537a375 100644 (file)
@@ -457,19 +457,19 @@ static int _genpd_power_off(struct generic_pm_domain *genpd, bool timed)
 
        time_start = ktime_get();
        ret = genpd->power_off(genpd);
-       if (ret == -EBUSY)
+       if (ret)
                return ret;
 
        elapsed_ns = ktime_to_ns(ktime_sub(ktime_get(), time_start));
        if (elapsed_ns <= genpd->states[state_idx].power_off_latency_ns)
-               return ret;
+               return 0;
 
        genpd->states[state_idx].power_off_latency_ns = elapsed_ns;
        genpd->max_off_time_changed = true;
        pr_debug("%s: Power-%s latency exceeded, new value %lld ns\n",
                 genpd->name, "off", elapsed_ns);
 
-       return ret;
+       return 0;
 }
 
 /**