scsi: elx: efct: Eliminate unnecessary boolean check in efct_hw_command_cancel()

clang warns:

drivers/scsi/elx/efct/efct_hw.c:1523:17: warning: address of array
'ctx->buf' will always evaluate to 'true' [-Wpointer-bool-conversion]
                              (!ctx->buf ? U32_MAX : *((u32 *)ctx->buf)));
                               ~~~~~~^~~

buf is an array in the middle of a struct so deferencing it is not a
problem as long as ctx is not NULL. Eliminate the check, which fixes the
warning.

Link: https://github.com/ClangBuiltLinux/linux/issues/1398
Link: https://lore.kernel.org/r/20210617063123.21239-1-nathan@kernel.org
Fixes: 580c0255e4ef ("scsi: elx: efct: RQ buffer, memory pool allocation and deallocation APIs")
Reviewed-by: James Smart <jsmart2021@gmail.com>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/elx/efct/efct_hw.c b/drivers/scsi/elx/efct/efct_hw.c
index 6324683f9e8e009374e9720df491f47cdcdddb17..cde1cf6f03bd1d01ca2a6f318205f14b0cf8e647 100644 (file)
--- a/drivers/scsi/elx/efct/efct_hw.c
+++ b/drivers/scsi/elx/efct/efct_hw.c
@@ -1519,8 +1519,7 @@ efct_hw_command_cancel(struct efct_hw *hw)
                                       struct efct_command_ctx, list_entry);
 
                efc_log_debug(hw->os, "hung command %08x\n",
-                             !ctx ? U32_MAX :
-                             (!ctx->buf ? U32_MAX : *((u32 *)ctx->buf)));
+                             !ctx ? U32_MAX : *((u32 *)ctx->buf));
                spin_unlock_irqrestore(&hw->cmd_lock, flags);
                rc = efct_hw_command_process(hw, -1, mqe, SLI4_BMBX_SIZE);
                spin_lock_irqsave(&hw->cmd_lock, flags);