media: dw100: Add a missing unwind goto in dw100_probe()
authorXavier Roumegue <xavier.roumegue@oss.nxp.com>
Tue, 3 Jan 2023 10:55:34 +0000 (11:55 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Sun, 22 Jan 2023 08:26:14 +0000 (09:26 +0100)
In case the IRQ allocation returns an error in dw100_probe(), the pm
runtime is not disabled before to return.

Add the missing unwind goto on the error handling path of the IRQ
allocation request.

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Xavier Roumegue <xavier.roumegue@oss.nxp.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/platform/nxp/dw100/dw100.c

index f6d48c36f386075bcaa05e6a0b086ff3d2342bb2..189d60cd5ed130c14d61b1a13c0ea992f074684a 100644 (file)
@@ -1571,7 +1571,7 @@ static int dw100_probe(struct platform_device *pdev)
                               dev_name(&pdev->dev), dw_dev);
        if (ret < 0) {
                dev_err(&pdev->dev, "Failed to request irq: %d\n", ret);
-               return ret;
+               goto err_pm;
        }
 
        ret = v4l2_device_register(&pdev->dev, &dw_dev->v4l2_dev);