projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
504e2be
)
scsi: qedf: Make qedf_execute_tmf() non-preemptible
author
John Meneghini
<jmeneghi@redhat.com>
Wed, 3 Apr 2024 15:01:55 +0000
(11:01 -0400)
committer
Martin K. Petersen
<martin.petersen@oracle.com>
Thu, 25 Apr 2024 00:58:53 +0000
(20:58 -0400)
Stop calling smp_processor_id() from preemptible code in
qedf_execute_tmf90. This results in BUG_ON() when running an RT kernel.
[ 659.343280] BUG: using smp_processor_id() in preemptible [
00000000
] code: sg_reset/3646
[ 659.343282] caller is qedf_execute_tmf+0x8b/0x360 [qedf]
Tested-by: Guangwu Zhang <guazhang@redhat.com>
Cc: Saurav Kashyap <skashyap@marvell.com>
Cc: Nilesh Javali <njavali@marvell.com>
Signed-off-by: John Meneghini <jmeneghi@redhat.com>
Link:
https://lore.kernel.org/r/20240403150155.412954-1-jmeneghi@redhat.com
Acked-by: Saurav Kashyap <skashyap@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qedf/qedf_io.c
patch
|
blob
|
history
diff --git
a/drivers/scsi/qedf/qedf_io.c
b/drivers/scsi/qedf/qedf_io.c
index bf921caaf6aea684d91b028a0a193f86edba0dea..054a51713d556351afbd3253853947d5a6693933 100644
(file)
--- a/
drivers/scsi/qedf/qedf_io.c
+++ b/
drivers/scsi/qedf/qedf_io.c
@@
-2324,9
+2324,6
@@
static int qedf_execute_tmf(struct qedf_rport *fcport, u64 tm_lun,
io_req->fcport = fcport;
io_req->cmd_type = QEDF_TASK_MGMT_CMD;
- /* Record which cpu this request is associated with */
- io_req->cpu = smp_processor_id();
-
/* Set TM flags */
io_req->io_req_flags = QEDF_READ;
io_req->data_xfer_len = 0;
@@
-2349,6
+2346,9
@@
static int qedf_execute_tmf(struct qedf_rport *fcport, u64 tm_lun,
spin_lock_irqsave(&fcport->rport_lock, flags);
+ /* Record which cpu this request is associated with */
+ io_req->cpu = smp_processor_id();
+
sqe_idx = qedf_get_sqe_idx(fcport);
sqe = &fcport->sq[sqe_idx];
memset(sqe, 0, sizeof(struct fcoe_wqe));