iavf: Fix error handling in iavf_init_module()

[ Upstream commit 227d8d2f7f2278b8468c5531b0cd0f2a905b4486 ]

The iavf_init_module() won't destroy workqueue when pci_register_driver()
failed. Call destroy_workqueue() when pci_register_driver() failed to
prevent the resource leak.

Similar to the handling of u132_hcd_init in commit f276e002793c
("usb: u132-hcd: fix resource leak")

Fixes: 2803b16c10ea ("i40e/i40evf: Use private workqueue")
Signed-off-by: Yuan Can <yuancan@huawei.com>
Tested-by: Konrad Jankowski <konrad0.jankowski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c
index f2f8f2a43a34d0eeb34f4f8cb27dae4c01a9c58f..82c4f1190e41c88510e3e1313e3cf917c02d8427 100644 (file)
--- a/drivers/net/ethernet/intel/iavf/iavf_main.c
+++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
@@ -4341,6 +4341,8 @@ static struct pci_driver iavf_driver = {
  **/
 static int __init iavf_init_module(void)
 {
+       int ret;
+
        pr_info("iavf: %s\n", iavf_driver_string);
 
        pr_info("%s\n", iavf_copyright);
@@ -4351,7 +4353,12 @@ static int __init iavf_init_module(void)
                pr_err("%s: Failed to create workqueue\n", iavf_driver_name);
                return -ENOMEM;
        }
-       return pci_register_driver(&iavf_driver);
+
+       ret = pci_register_driver(&iavf_driver);
+       if (ret)
+               destroy_workqueue(iavf_wq);
+
+       return ret;
 }
 
 module_init(iavf_init_module);