ACPI: processor idle: Use swap() instead of open coding it
authorGuo Zhengkui <guozhengkui@vivo.com>
Tue, 9 Nov 2021 07:50:51 +0000 (15:50 +0800)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 24 Nov 2021 16:46:12 +0000 (17:46 +0100)
Address the following coccicheck warning:

./drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c:914:40-41:
WARNING opportunity for swap().

by using swap() for the swapping of variable values and drop
the tmp variable that is not needed any more.

Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
[ rjw: Subject and changelog rewrite ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/processor_idle.c

index 76ef1bcc884809943b705c3d5ccd4554162bcfcd..4b906bb527e8ccc99f6c827d6d04ce303c8dd6e3 100644 (file)
@@ -20,6 +20,7 @@
 #include <linux/tick.h>
 #include <linux/cpuidle.h>
 #include <linux/cpu.h>
+#include <linux/minmax.h>
 #include <acpi/processor.h>
 
 /*
@@ -400,13 +401,10 @@ static int acpi_cst_latency_cmp(const void *a, const void *b)
 static void acpi_cst_latency_swap(void *a, void *b, int n)
 {
        struct acpi_processor_cx *x = a, *y = b;
-       u32 tmp;
 
        if (!(x->valid && y->valid))
                return;
-       tmp = x->latency;
-       x->latency = y->latency;
-       y->latency = tmp;
+       swap(x->latency, y->latency);
 }
 
 static int acpi_processor_power_verify(struct acpi_processor *pr)