erofs: remove WQ_CPU_INTENSIVE flag from unbound wq's
authorGao Xiang <hsiangkao@redhat.com>
Fri, 31 Jul 2020 02:40:49 +0000 (10:40 +0800)
committerGao Xiang <hsiangkao@redhat.com>
Mon, 3 Aug 2020 13:04:46 +0000 (21:04 +0800)
The documentation [1] says that WQ_CPU_INTENSIVE is "meaningless" for
unbound wq. I remove this flag from places where unbound queue is
allocated. This is supposed to improve code readability.

[1] https://www.kernel.org/doc/html/latest/core-api/workqueue.html#flags
Signed-off-by: Maksym Planeta <mplaneta@os.inf.tu-dresden.de>
[Gao Xiang: since the original treewide patch [2] hasn't been merged
            yet, handling the EROFS part only for the next cycle. ]
[2] https://lore.kernel.org/r/20200213141823.2174236-1-mplaneta@os.inf.tu-dresden.de
Link: https://lore.kernel.org/r/20200731024049.16495-1-hsiangkao@aol.com
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Gao Xiang <hsiangkao@redhat.com>
fs/erofs/zdata.c

index 80bf09c4de09d7b487f6b16741fae4bc56d429e8..9ac2723c11bfcfab9468b1aac9498c67f402c367 100644 (file)
@@ -43,13 +43,13 @@ void z_erofs_exit_zip_subsystem(void)
 static inline int z_erofs_init_workqueue(void)
 {
        const unsigned int onlinecpus = num_possible_cpus();
-       const unsigned int flags = WQ_UNBOUND | WQ_HIGHPRI | WQ_CPU_INTENSIVE;
 
        /*
         * no need to spawn too many threads, limiting threads could minimum
         * scheduling overhead, perhaps per-CPU threads should be better?
         */
-       z_erofs_workqueue = alloc_workqueue("erofs_unzipd", flags,
+       z_erofs_workqueue = alloc_workqueue("erofs_unzipd",
+                                           WQ_UNBOUND | WQ_HIGHPRI,
                                            onlinecpus + onlinecpus / 4);
        return z_erofs_workqueue ? 0 : -ENOMEM;
 }