spi: tegra20-slink: change chip select action order

To transfer via SPI the tegra20-slink driver first sets the command
register, which contains the chip select value, and after that the
command2 register, which contains the chip select line. This leads to a
small spike in the chip selct 0 line between the set of the value and
the selection of the chip select line.

This commit changes the order of the register writes so that first the
chip select line is chosen and then the value is set, removing the
spike.

Signed-off-by: Randolph Maaßen <gaireg@gaireg.de>
Reviewed-by: Sowjanya Komatineni <skomatineni@nvidia.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/drivers/spi/spi-tegra20-slink.c b/drivers/spi/spi-tegra20-slink.c
index 1427f343b39a3dc4468e14c3612814508993b3c0..6d46791262136328390f79f42b37a52f3645960e 100644 (file)
--- a/drivers/spi/spi-tegra20-slink.c
+++ b/drivers/spi/spi-tegra20-slink.c
@@ -717,9 +717,6 @@ static int tegra_slink_start_transfer_one(struct spi_device *spi,
        command2 = tspi->command2_reg;
        command2 &= ~(SLINK_RXEN | SLINK_TXEN);
 
-       tegra_slink_writel(tspi, command, SLINK_COMMAND);
-       tspi->command_reg = command;
-
        tspi->cur_direction = 0;
        if (t->rx_buf) {
                command2 |= SLINK_RXEN;
@@ -729,9 +726,18 @@ static int tegra_slink_start_transfer_one(struct spi_device *spi,
                command2 |= SLINK_TXEN;
                tspi->cur_direction |= DATA_DIR_TX;
        }
+
+       /*
+        * Writing to the command2 register bevore the command register prevents
+        * a spike in chip_select line 0. This selects the chip_select line
+        * before changing the chip_select value.
+        */
        tegra_slink_writel(tspi, command2, SLINK_COMMAND2);
        tspi->command2_reg = command2;
 
+       tegra_slink_writel(tspi, command, SLINK_COMMAND);
+       tspi->command_reg = command;
+
        if (total_fifo_words > SLINK_FIFO_DEPTH)
                ret = tegra_slink_start_dma_based_transfer(tspi, t);
        else