vfio: avoid possible overflow in vfio_iommu_type1_pin_pages
authorYan Zhao <yan.y.zhao@intel.com>
Wed, 8 Apr 2020 07:12:34 +0000 (03:12 -0400)
committerAlex Williamson <alex.williamson@redhat.com>
Mon, 20 Apr 2020 18:40:16 +0000 (12:40 -0600)
add parentheses to avoid possible vaddr overflow.

Fixes: a54eb55045ae ("vfio iommu type1: Add support for mediated devices")
Signed-off-by: Yan Zhao <yan.y.zhao@intel.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
drivers/vfio/vfio_iommu_type1.c

index aa501e826e703665796047f4f78cee2386a5a791..fbc58284b3336e96058f7e4ce4c6d71512c7fcf4 100644 (file)
@@ -555,7 +555,7 @@ static int vfio_iommu_type1_pin_pages(void *iommu_data,
                        continue;
                }
 
-               remote_vaddr = dma->vaddr + iova - dma->iova;
+               remote_vaddr = dma->vaddr + (iova - dma->iova);
                ret = vfio_pin_page_external(dma, remote_vaddr, &phys_pfn[i],
                                             do_accounting);
                if (ret)